Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referral Expired error #33775

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Referral Expired error #33775

merged 5 commits into from
Jan 10, 2025

Conversation

juancstlm-a6
Copy link
Contributor

@juancstlm-a6 juancstlm-a6 commented Dec 27, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds a referral expired error when a referral is past it's expiration date

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Screen Shot 2024-12-27 at 11 25 30 Screen Shot 2024-12-30 at 16 50 57
Desktop Screenshot 2024-12-27 at 11-23-59 Appointments Veterans Affairs Screenshot 2024-12-30 at 16-50-54 Appointments Veterans Affairs

What areas of the site does it impact?

  • VAOS

Acceptance criteria

  • Create alert markup in component
  • Add unit test for expired state

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

@juancstlm-a6 juancstlm-a6 linked an issue Dec 27, 2024 that may be closed by this pull request
2 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main December 27, 2024 02:15 Inactive
@juancstlm-a6 juancstlm-a6 force-pushed the 95286-referral-has-expired-error branch from bd94668 to 539ea0f Compare December 30, 2024 18:18
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main December 30, 2024 18:31 Inactive
@@ -508,7 +508,7 @@ const responses = {
});
},
'GET /vaos/v2/epsApi/referralDetails/:referralId': (req, res) => {
const referrals = referralUtils.createReferrals(3, '2024-12-02');
const referrals = referralUtils.createReferrals(3, '2024-12-02', 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of your changes, but we should probably not hard code this date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Contributor

@brianseek brianseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juancstlm-a6 this looks great to me. One small thing is that it looks like there should be more margin between the "Call your facility to request a new referral." sentence and the "Find your VA health facility" link according to the figma.
Screenshot 2024-12-30 at 11 21 10 AM

@juancstlm-a6
Copy link
Contributor Author

@brianseek Updated the margins as well as the screenshots

@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main December 30, 2024 23:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main December 30, 2024 23:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main December 31, 2024 00:36 Inactive
brianseek
brianseek previously approved these changes Dec 31, 2024
Copy link
Contributor

@brianseek brianseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@juancstlm-a6
Copy link
Contributor Author

@ryanshaw this pr is ready for review

Test Plan

  1. Visit my-health/appointments/?id=445e2d1b-7150-4631-97f2-f6f473bdef00
  2. Observe the referral task card is no longer showing and are presented with the expired alert

@juancstlm-a6 juancstlm-a6 marked this pull request as ready for review December 31, 2024 22:15
@juancstlm-a6 juancstlm-a6 requested review from a team as code owners December 31, 2024 22:16
ryanshaw
ryanshaw previously approved these changes Jan 7, 2025
Copy link
Contributor

@ryanshaw ryanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juancstlm-a6 juancstlm-a6 dismissed stale reviews from ryanshaw and brianseek via 13fc6c1 January 7, 2025 06:53
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main January 7, 2025 06:55 Inactive
@juancstlm-a6
Copy link
Contributor Author

@ryanshaw Mind re-approving? had to resolve a conflict

@juancstlm-a6 juancstlm-a6 force-pushed the 95286-referral-has-expired-error branch from 13fc6c1 to 3d353f9 Compare January 7, 2025 18:28
ryanshaw
ryanshaw previously approved these changes Jan 7, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main January 7, 2025 18:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/95286-referral-has-expired-error/main January 7, 2025 18:56 Inactive
@juancstlm-a6
Copy link
Contributor Author

@ryanshaw One last time a re-approval pls!

@juancstlm-a6 juancstlm-a6 requested a review from ryanshaw January 8, 2025 17:46
@juancstlm-a6 juancstlm-a6 merged commit 33de1d3 into main Jan 10, 2025
79 checks passed
@juancstlm-a6 juancstlm-a6 deleted the 95286-referral-has-expired-error branch January 10, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referral has expired error
4 participants